-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Istio upstream tests #9463
Merged
Merged
Add Istio upstream tests #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into npolshak/istio-k8s-gw-e2e-test
Visit the preview URL for this PR (updated for commit 93dad84): https://gloo-edge--pr9463-npolshak-add-istio-u-pbs2lyjw.web.app (expires Thu, 23 May 2024 16:01:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
sam-heilbron
previously approved these changes
May 15, 2024
4 tasks
jbohanon
reviewed
May 16, 2024
test/kubernetes/e2e/features/istio/gloo_gateway_auto_mtls_suite.go
Outdated
Show resolved
Hide resolved
jbohanon
previously approved these changes
May 16, 2024
sam-heilbron
approved these changes
May 16, 2024
jbohanon
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Istio integration tests with Upstreams.
Upgrade/downgrade doc for Istio automtls integration: https://docs.google.com/document/d/1QmapbTCVb6BIrgkmgeL60lSwL5KLLIn_MN2KiRLW-is/edit?usp=sharing
Code changes
This introduces the following net new tests:
These can be added if we decide they are worthwhile:
glooctl istio enable-mtls --upstream httpbin-upstream
, removing the SSL config withglooctl istio disable-mtls --upstream httpbin-upstream
. Currently the tests directly apply the Upstream with sslConfig since discovery is disabled on the Istio tests. The original Istio regression tests were using discovery and editing the Upstream through the cli. This can cause flakes when updating the Upstream resource.Manual validation:
I checked the
X-Forwarded-Client-Cert
was present by grepping the response:Checklist: